search

0xProject / ZEIPs

0x Improvement Proposals
Apache License 2.0
91 stars 24 forks source link

Delay 3.0 launch until December 2 #72

Closed abandeali1 closed 4 years ago

abandeali1 commented 4 years ago

Summary

2 minor issues were discovered by the 0x team in the 14 day grace period leading up to the 3.0 launch (as outlined below). Given that the mainnet contract configurations are not yet live, we recommend redeploying the 3.0 contracts and and resubmitting their configurations to the ZeroExGovernor, restarting the 14 day grace period.

  1. Rounding in the wrong direction in marketBuyOrdersNoThrow causes a high failure rate in marketBuyOrdersFillOrKill. Note that this bug also exists in the 2.0 contracts, but it only really becomes problematic in the new fillOrKill counterpart. We expect marketBuyOrdersFillOrKill to be one of the most used functions within the Exchange contract, so it is important that this is patched. This issue has been fixed here.

  2. An off by one error led to staking pool operators only being able to specify a maximum operator share of 99.9999%. This issue has been fixed here.

Motivation

Delaying the upgrade now minimizes any future migration overhead. This will also give developers an extra week to prepare for the migration.