0xProject / tools

Other
97 stars 64 forks source link

@0x/sol-profiler not working with solc 0.7.6 #34

Open lcswillems opened 3 years ago

lcswillems commented 3 years ago

Expected Behavior

@0x/sol-profiler works with solc 0.7.5 but not with 0.7.6.

Here is a reproduction: https://github.com/lcswillems/0x-profiler-error-0.7.6

I get this error:

TypeError: Cannot read property 'split' of undefined
    at Object.parseSourceMap (/mnt/Data/Downloads/dev-tools-truffle-example/node_modules/@0x/sol-tracing-utils/src/source_maps.ts:53:28)
    at TraceCollector.<anonymous> (/mnt/Data/Downloads/dev-tools-truffle-example/node_modules/@0x/sol-tracing-utils/src/trace_collector.ts:106:33)
    at Generator.next (<anonymous>)
    at fulfilled (/mnt/Data/Downloads/dev-tools-truffle-example/node_modules/@0x/sol-tracing-utils/lib/src/trace_collector.js:5:58)

After investigation, it seems the profiler assumes contract artifact contains a field compilerOutput.evm.deployedBytecode.sourceMap which is not the case.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

lcswillems commented 3 years ago

I don't think it should be closed.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

lcswillems commented 3 years ago

I don't think it should be closed.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

lcswillems commented 2 years ago

I don't think it should be closed.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.