search

0xProject / tools

Other
97 stars 64 forks source link

0x/subproviders Trezor EIP-712 update #56

Closed 0xShisui closed 2 years ago

0xShisui commented 2 years ago

According to the implementation here https://github.com/0xProject/tools/blob/development/subproviders/src/subproviders/trezor.ts#L157 eth_signTypedData are not supported by Trezor.

However, Trezor supports it now (it's really recent tho) Implementation : https://github.com/trezor/connect/commit/08e43827927101dbe3f739f825810e9b565ff932 Doc: https://github.com/trezor/connect/blob/develop/docs/methods/ethereumSignTypedData.md

Do you have any plan to add this to the TrezorSubprovider ?

Thank you.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.