0xSooki / erc721-rarity-generator

Generates rarity ranking based off a contract address, using Alchemy
MIT License
3 stars 4 forks source link

Feature/improve db interactions #13

Closed fekete965 closed 1 year ago

fekete965 commented 1 year ago

Related Issues

Types of changes

Description

DB and File System interactions have been extracted. Improved the way we connect to the DB and we added the ability to insert multiple records in one go into the DB.

Fixes # (issue)

This PR will address the following issue: #10

Added to documentation?

Checklist:

fekete965 commented 1 year ago

Last 4 commits only!

fekete965 commented 1 year ago

@0xSooki issues have been resolved. :)

0xSooki commented 1 year ago

Amazing, will check it tomorrow morning but it seems perfect, great job :)

0xSooki commented 1 year ago

Just one quick thing, could you please change the target branch to develop?

fekete965 commented 1 year ago

Ah my bad! I accidentally rebased to main. 🤦

fekete965 commented 1 year ago

@0xSooki all done. Finally, a clean commit tree :)

0xSooki commented 1 year ago

Amazing, thank you :)