Add support for multiple rarity calculation methods

0xSooki / erc721-rarity-generator

Generates rarity ranking based off a contract address, using Alchemy

MIT License

3 stars 4 forks source link

Add support for multiple rarity calculation methods #2

Open 0xSooki opened 1 year ago

0xSooki commented 1 year ago

Expected Behaviour

Be able to select between multiple rarity calculation methods (see methods here)

Current Behaviour

As of now it only uses one method

Detailed Description

The users should be able to select between the different rarity calculation methods & generate the data based on the selected method

Possible Implementation

Create a rarity.js file
Create functions for the different methods
Implement these functions in the main.js file

prateekvarma commented 1 year ago

Hi @0xSooki I'd like to take a shot at this one.

(participating for Hacktoberfest)

0xSooki commented 1 year ago

Haii, sure, go ahead keep in mind that this is a bit harder issue to tackle

fekete965 commented 1 year ago

@0xSooki I have already extracted some of the functionalities in my PR. @prateekvarma if you still wish to work on this issue, you could rebase on top of my PR #6

prateekvarma commented 1 year ago

Thanks @fekete965 and @0xSooki

0xSooki commented 1 year ago

@prateekvarma any progress towards the issue?

prateekvarma commented 1 year ago

Hi @0xSooki my apologies, I'm still doing some tutorials and lessons from Alchemy. Haven't worked with anything related to web3 yet. I will post an updated soon.

0xSooki commented 1 year ago

It's okay, take your time