search

0xSooki / erc721-rarity-generator

Generates rarity ranking based off a contract address, using Alchemy
MIT License
3 stars 4 forks source link

Feature/refactor codebase #6

Closed fekete965 closed 2 years ago

fekete965 commented 2 years ago

PR for issue #3

0xSooki commented 2 years ago

Amazing, thank you. Could you please change the target branch to develop instead of main?

fekete965 commented 2 years ago

@0xSooki yes, of course. :)

fekete965 commented 2 years ago

@0xSooki all done. 💪

0xSooki commented 2 years ago

Would you mind solving conflicts regarding the mongodb update? As you did an amazing job with the repo so it would be much appreciated

fekete965 commented 2 years ago

Yes, of course! I'll resolve any conflict :)

0xSooki commented 2 years ago

Thank you, much appreciated :)

fekete965 commented 2 years ago

@0xSooki I had some trouble to checkout to my branch after I have changed the origin of it to develop. I did resolve the conflicts, but I was not able to test it myself locally.

I will create an "issue" where I would propose something regarding data saving to the DB and I will also be able to test my changes properly.

Sorry for the trouble!

0xSooki commented 2 years ago

It's totally okay, take your time, you've already did an amazing job

fekete965 commented 2 years ago

@0xSooki Conflict should be resolved.