search

0xSpaceShard / starknet-devnet-rs

A local testnet for Starknet... in Rust
https://0xspaceshard.github.io/starknet-devnet-rs/
MIT License
104 stars 60 forks source link

Unnecessary derive #188

Open FabijanC opened 11 months ago

FabijanC commented 11 months ago

I realized we put a lot of unnecessary #[derive] attributes to our struct definitions. I believe this is increases both the compilation time and the binary size. E.g. some structs are only serialized, so they don't need #[derive(Deserialize)].

Perhaps we could only add these attributes when we really need them. To completely resolve this task, someone would need to go through all the structs and see if the derivation of some traits can be removed.

Let me know if I'm wrong and this doesn't have such an impact as it seems to me.

greged93 commented 7 months ago

hey, I can take a look if this is still available

ivpavici commented 7 months ago

@greged93 sure!

ivpavici commented 5 months ago

@greged93 any progress?

greged93 commented 5 months ago

hey @ivpavici, got side tracked, if you need this urgently then better to remove me, otherwise can do it this week-end

ivpavici commented 5 months ago

ok if you want to continue lets see next week!

g4titanx commented 4 months ago

hello @ivpavici i would love to work on this

ivpavici commented 4 months ago

@g4titanx we will wait for the ODHack to commence

g4titanx commented 4 months ago

alright!

g4titanx commented 4 months ago

hello @ivpavici can you assign the task to me now?

ivpavici commented 4 months ago

@g4titanx only one assignee per issue!

fishonamos commented 4 months ago

Hi @ivpavici . I can work on this.