Closed FabijanC closed 2 weeks ago
Hey there! This sounds like a good first issue to work on and try my rust skills! Could I get assigned to it? I also understand Python so checking out the devnet-py test will be easy.
@joseSalazar4 you've been assigned
Try adding two more tests:
If you feel the tests are too similar, then just add one.
In any case, feel free to create at least a draft PR even if you're not yet done (but indicating so). That way we can see exactly what you've done so far and make concrete suggestions.
Tests in
crates/starknet-devnet/tests/test_simulate_transactions.rs
were written to have the same coverage as devnet-py the corresponding devnet-py tests. Currently there are TODOs:- Another test needs replacement of .ge with .gt (basically we would want to assert that using SKIP_VALIDATE actually lowers the estimated fee, but currently it does not have effect, as described in this issue: https://github.com/lambdaclass/starknet_in_rust/issues/1051)This issue can be addressed separately as it would not merely be enhancement but fix.simulate(...)
instead of manually constructing simulation requests.