0xSpaceShard / starknet-devnet-rs

A local testnet for Starknet... in Rust
https://0xspaceshard.github.io/starknet-devnet-rs/
MIT License
107 stars 62 forks source link

Improve testing of starknet_simulateTransactions #192

Closed FabijanC closed 2 weeks ago

FabijanC commented 1 year ago

Tests in crates/starknet-devnet/tests/test_simulate_transactions.rs were written to have the same coverage as devnet-py the corresponding devnet-py tests. Currently there are TODOs:

joseSalazar4 commented 6 months ago

Hey there! This sounds like a good first issue to work on and try my rust skills! Could I get assigned to it? I also understand Python so checking out the devnet-py test will be easy.

FabijanC commented 6 months ago

@joseSalazar4 you've been assigned

FabijanC commented 6 months ago

Try adding two more tests:

If you feel the tests are too similar, then just add one.

In any case, feel free to create at least a draft PR even if you're not yet done (but indicating so). That way we can see exactly what you've done so far and make concrete suggestions.