search

0xSpaceShard / starknet-devnet-rs

A local testnet for Starknet... in Rust
https://0xspaceshard.github.io/starknet-devnet-rs/
MIT License
104 stars 61 forks source link

Update OpenZeppelin contracts to 0.9.0 #352

Open mikiw opened 6 months ago

mikiw commented 6 months ago

https://github.com/OpenZeppelin/cairo-contracts/blob/v0.9.0/src/token/erc20/erc20.cairo

remember about removing the #[key] keyword from the event in erc20 contracts so it is not indexed (related to https://github.com/0xSpaceShard/starknet-devnet-rs/pull/356)

mikiw commented 6 months ago

Seems that the current OZ wizard doesn't support the mintable feature for v0.9.0.

Due to this problem and the urgency of key attribute comments, this will need to be handled in 2 separate PRs.

Changing status to on hold.

FabijanC commented 5 months ago

Perhaps UDC can also be updated with this issue

ivpavici commented 5 months ago

v0.11 came out in the meantime!

FabijanC commented 3 months ago

v0.13 is out: https://github.com/OpenZeppelin/cairo-contracts/releases/tag/v0.13.0

mikiw commented 2 months ago

Seems that the update of UDC requires a version of starknet.rs that supports the selector "deploy_contract" (0.13.0 cairo1) instead of "deployContract" (0.5.0 cairo0)

https://github.com/xJonathanLEI/starknet-rs/blob/36ec1d681fc2917ca4857d14ce262ed7c2b60a7a/starknet-contract/src/factory.rs#L16