create devnet specific endpoints

0xSpaceShard / starknet-devnet-rs

A local testnet for Starknet... in Rust

https://0xspaceshard.github.io/starknet-devnet-rs/

MIT License

104 stars 60 forks source link

create devnet specific endpoints #468

Closed mubarak23 closed 3 months ago

mubarak23 commented 3 months ago

Usage related changes

Checklist:

[ ] API unification to follow JSON-RPC Spec #463
[ ] Json-RPC call with both devnet prefix and non devnet prefix
[ ] main the old setup while ensuring the added prefix work with route action

mubarak23 commented 3 months ago

If this PR is work in progress, please consider converting it to draft. Sorry to see that you didn't like the default PR checklist, it's very useful. Note that there are conflicts with main after #469.

i will look into it and fix it

mubarak23 commented 3 months ago

@FabijanC this is the PR, kindly review

mubarak23 commented 3 months ago

This is wrong. The idea is to make existing functionality (like minting) available via the /rpc endpoint, not introduce new endpoints. So, not to introduce /devnet_mint, but to have /rpc accept:
POST /rpc
{
  "method": "devnet_mint",
  ...
}
This is explained in #463

i see, i will change it

FabijanC commented 3 months ago

@mubarak23 Any progress? Or do you want to be unassigned?

mubarak23 commented 3 months ago

@mubarak23 Any progress? Or do you want to be unassigned?

Yaah, please unsigned and assigned it to someone.

Thank you