0xSpaceShard / starknet-devnet-rs

A local testnet for Starknet... in Rust
https://0xspaceshard.github.io/starknet-devnet-rs/
MIT License
104 stars 60 forks source link

Pending block and state improvements #480

Closed mikiw closed 3 months ago

mikiw commented 3 months ago

Usage related changes

Checklist:

mikiw commented 3 months ago

TODO: https://github.com/0xSpaceShard/starknet-devnet-rs/issues/474 is fixed by this PR buy remember to add test for that

mikiw commented 3 months ago

I also tried to fix hardcoded nonces in blocks_on_demand_tests but I couldn't.

I tried to use predeployed_account.lock().unwrap().set_block_id(BlockId::Tag(BlockTag::Pending)); but it led to the problem with a clone the method clone exists for struct SingleOwnerAccount<JsonRpcClient<HttpTransport>, LocalWallet>, but its trait bounds were not satisfied.

https://github.com/0xSpaceShard/starknet-devnet-rs/compare/main...pending-block-improvments-test-check-nonce-bug here is a branch - Alea iacta est if anyone can fix it it would be great, maybe my rust skills are not sufficient.

I would just wait for starknet-rs update and just remove it later.