fix `get_block_txs_count` endpoint error code - Githubissues

0xSpaceShard / starknet-devnet-rs

A local testnet for Starknet... in Rust

https://0xspaceshard.github.io/starknet-devnet-rs/

MIT License

104 stars 60 forks source link

fix `get_block_txs_count` endpoint error code #496

Closed tonypony220 closed 2 months ago

tonypony220 commented 2 months ago

Describe the bug (observed vs expected behavior) https://github.com/starkware-libs/starknet-specs/blob/304b952121dafe47c013ed2c4c39bef4cf4c2823/api/starknet_api_openrpc.json#L559 should return BLOCK_NOT_FOUND, but returns NO_BLOCKS

https://github.com/0xSpaceShard/starknet-devnet-rs/blob/3ad81456092a2da939be1f590855cea2c18ce40c/crates/starknet-devnet-server/src/api/json_rpc/endpoints.rs#L261

FabijanC commented 2 months ago

Thanks for reporting! Is this a blocker for you?

tonypony220 commented 2 months ago

@FabijanC afaik it's not.