Closed mikiw closed 2 weeks ago
I think that this is_max_fee_zero_value
function should be renamed and abstracted as a validate()
function, seems more robust and convenient but it's leading to error mapping problem...
abstractions improvements that could allow to return of different error types due to different validation problems is leading to major code refactoring for invoke, deploy, declare transactions which all rely on is_max_fee_zero_value()
function
it leads to the idea of just a detailed error string:
#[error(
"{tx_type}: max_fee cannot be zero (exception is v3 transaction where l2 gas must be zero)"
)]
but I'm not happy with that solution :pensive:
Usage related changes
resource_bounds
input forl2_gas
behave same as mainetChecklist:
./scripts/format.sh
./scripts/clippy_check.sh
./scripts/check_unused_deps.sh
./scripts/check_spelling.sh
./website/README.md