0xSpaceShard / starknet-devnet

A local testnet for Starknet
https://0xspaceshard.github.io/starknet-devnet/
MIT License
211 stars 77 forks source link

Unable to use web3.py to work with Ethereum when starknet-devnet is installed in same env #168

Closed antazoey closed 2 years ago

antazoey commented 2 years ago

Describe the bug In projects that use both Ethereum and Starknet, we need web3.py to facilitate deploying Ethereum transactions. However, we are running into eth-abi encoding issues regarding address arguments to the transactions. We notice that this only occurs when starknet-devnet is installed. When starknet-devnet is uninstalled, the transactions work as expected. Otherwise, we are unable to pass addresses as arguments to them.

To Reproduce

Expected behavior

Able to still use Ethereum when starknet-devnet is installed

Screenshots If applicable, add screenshots to help explain your problem. However, prefer providing copyable text.

Devnet version

Machine specifications

ca11ab1e commented 2 years ago

Finally fixed here:

FabijanC commented 2 years ago

@ca11ab1e Fixed in what sense? This was an issue on your side?

ca11ab1e commented 2 years ago

Yes, it was an issue on my side.

@unparalleled-js should confirm, but the issue was that as soon as ape-starknet was installed, it was being used for non-Starknet stuff. For instance Ape was trying to decode Solidity contract addresses using the Starknet-specific function. If I'm right, and not off-topic, that's not a devnet issue.