search

0xSpaceShard / starknet-devnet

A local testnet for Starknet
https://0xspaceshard.github.io/starknet-devnet/
MIT License
211 stars 77 forks source link

JSON-RPC API trace methods are missing #481

Closed FabijanC closed 1 year ago

FabijanC commented 1 year ago

The three methods should be added: https://github.com/starkware-libs/starknet-specs/blob/v0.3.0-rc1/api/starknet_trace_api_openrpc.json

The link is for v0.3.0-rc1, but whichever is the current version at the time of development should be added (e.g. v0.3.0)

Note from Ariel:

...some of the methods there are still not implemented by existing nodes. For example, Pathfinder recently added simulate , but for nodes who don’t re-execute txs and rely on proofs, traceTransaction is problematic because it may require the replay of the entire block (this is currently unsupported there).

ivpavici commented 1 year ago

For starknet.js, starknet_simulateTransaction is the most important one

mikiw commented 1 year ago

so I started with starknet_simulateTransaction and yes v0.3.0 is there https://github.com/starkware-libs/starknet-specs/blob/v0.3.0/api/starknet_trace_api_openrpc.json

mikiw commented 1 year ago

PR with starknet_simulateTransaction is here https://github.com/0xSpaceShard/starknet-devnet/pull/492

starknet_traceTransaction and starknet_traceBlockTransactions will be added later

mikiw commented 1 year ago

https://github.com/0xSpaceShard/starknet-devnet/pull/492 PR with starknet_simulateTransaction was merged