Refactor estimation and simulation - Githubissues

0xSpaceShard / starknet-devnet

A local testnet for Starknet

https://0xspaceshard.github.io/starknet-devnet/

MIT License

211 stars 77 forks source link

Refactor estimation and simulation #506

Closed FabijanC closed 1 year ago

FabijanC commented 1 year ago

Usage related changes

N/A

Development related changes

Close #498
- StarknetWrapper::calculate_traces_and_fees now doesn't have the responsibility of extracting the tx types
- RPC changes:
- Fix typing
- simulateTransaction and estimateFee now using a common method

Checklist:

[x] Applied formatting - ./scripts/format.sh
[x] No linter errors - ./scripts/lint.sh
[x] Performed code self-review
[x] Rebased to the last commit of the target branch (or merged it into my branch)
[x] Documented the changes
[x] Linked the issues which this PR resolves
[ ] Updated the tests
[x] All tests are passing - ./scripts/test.sh