feat: add TransactionStatus.REVERTED to status

[kasteph]

Usage related changes

• add TransactionStatus.REVERTED to status

Development related changes

Checklist:

• [ ] Applied formatting - ./scripts/format.sh
• [ ] No linter errors - ./scripts/lint.sh
• [ ] Performed code self-review
• [ ] Rebased to the last commit of the target branch (or merged it into my branch)
• [ ] Documented the changes
• [ ] Linked the issues which this PR resolves
• [ ] Updated the tests
• [ ] All tests are passing - ./scripts/test.sh

[FabijanC]

Can you give an example of an issue that this PR resolves?

[kasteph]

@FabijanC sure! There could be a case where a contract/account has a status of Reverted. However, because this doesn't exist in that dictionary, it raises a KeyError and thus the server ultimately returns an HTTP 500 to the client.

[FabijanC]

I thought that perhaps you would have a ready example, but I see your point

In any case, this Devnet supports only JSON-RPC specification 0.3.0 (the latest stable version is 0.4.0 and there is 0.5.0 incoming; link to spec versions). In that sense, 0.3.0 does not yet mention tx reversion, so this status was not added to Devnet.

If your PR does not in any way break the existing functionality, it could be merged, but I'd wait until Monday since it's the end of the work day (and week) in my time zone.

Devnet has mostly been rewritten in Rust, with some features still pending. You can check out the devnet-rs repo. It currently supports JSON-RPC v0.4.0, with the trace API (e.g. simulateTransactions) being added at the time of writing this.

[FabijanC]

Let me know if this is a high priority for you.

[FabijanC]

@kasteph Then I guess it's not a high priority.

[kasteph]

Hi @FabijanC, yes, it's not a priority. I was able to find a workaround. I'll close this issue and start looking at the Rust implementation.