Cairo 1 compilation needs to be fixed - Githubissues

0xSpaceShard / starknet-hardhat-plugin

A plugin for integrating Starknet tools into Hardhat projects

https://0xspaceshard.github.io/starknet-hardhat-plugin/

MIT License

198 stars 36 forks source link

Cairo 1 compilation needs to be fixed #384

Closed FabijanC closed 1 year ago

FabijanC commented 1 year ago

getCompilerBinDir is used in the wrong way here (ther order of arguments should be reversed): https://github.com/0xSpaceShard/starknet-hardhat-plugin/blob/afc83b3a5892caab6cfbc64701422521f4de43af/src/task-actions.ts#L93
Cairo 2 compilation not supported due to this check: https://github.com/0xSpaceShard/starknet-hardhat-plugin/blob/afc83b3a5892caab6cfbc64701422521f4de43af/src/types/index.ts#L387-L389

FabijanC commented 1 year ago

Part of this issue has been transferred to #387