0xSpaceShard / starknet-hardhat-plugin

A plugin for integrating Starknet tools into Hardhat projects
https://0xspaceshard.github.io/starknet-hardhat-plugin/
MIT License
198 stars 36 forks source link

ContractAddress, ClassHash and EthAddress decoding #385

Open notV4l opened 1 year ago

notV4l commented 1 year ago

Actually this types are handle as common numeric types :

https://github.com/0xSpaceShard/starknet-hardhat-plugin/blob/afc83b3a5892caab6cfbc64701422521f4de43af/src/adapt.ts#L8-L20

It could be converted to hex representation ie : 3407481119780572850671182801001023516830125398818876583940565901076194792664 would decode to 0x78890e347461d95a8eacddaeb35b577f4ef29a6fbf825326d8d97022e2a14d8

FabijanC commented 1 year ago

Would make sense for ContractAddress, ClassHash and EthAddress. But this would be a breaking change.