search

0xSpaceShard / starknet-hardhat-plugin

A plugin for integrating Starknet tools into Hardhat projects
https://0xspaceshard.github.io/starknet-hardhat-plugin/
MIT License
198 stars 36 forks source link

Improve macos testing in CI/CD #386

Open FabijanC opened 1 year ago

FabijanC commented 1 year ago

Currently we rely on the venv-tests group, but it's very reduced. E.g. we should test how integrated tools can be used there: cairo1 compiler, scarb, integrated devnet

One problem I ran into while trying to add a scarb test: declaring a cairo 1 contract required devnet to be able to recompile, and it couldn't do so because the default starknet-sierra-compiler from the cairo-lang package is an executable compatible only with x86 (and our executor on circleci is m1 I believe). Using the installed cairo 1 compiler was not an option because it's only installed in configuration-tests.

Currently the only way to test if something works on mac is to have it tested by a developer with a mac machine.

FabijanC commented 1 year ago

Proposition: each test could have a JSON file where target OS can be specified. Similar to how target networks are specified in network.json