search

0xSplits / splits-sdk

An SDK for building apps on top of 0xSplits
https://docs.splits.org/sdk
MIT License
32 stars 12 forks source link

feat: add splits v2 support #29

Closed r0ohafza closed 6 months ago

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
splits-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 4:53am
mihoward21 commented 8 months ago

ok went through it all. might have some more thoughts on some of it after we chat.

mihoward21 commented 8 months ago

ok all done. don't think anything big? but happy to discuss anything that's confusing or you want to talk about or anything.

mihoward21 commented 7 months ago

ok was not able to look at any test stuff. but think i got through everything else

actuallymentor commented 7 months ago

Hello @mihoward21!

Should I read from this PR that the sdk does not work with V2 splits? I'm running into a lot of issues trying to get the sdk to work (see #39) and this might explain that...

Are currently created splits of the V1 or V2 variety and would that influence the viability of this sdk package?

mihoward21 commented 6 months ago

@r0ohafza feel free to merge this to the v4 branch whenever