0xStarcat / CircularNatalHoroscopeJS

An ES6 library for many astrological chart calculations.
The Unlicense
253 stars 74 forks source link

The first condition should be d (I mean x value in the formula) used instead of the ascendant value found #1

Closed Augustpi closed 4 years ago

Augustpi commented 4 years ago

https://github.com/0xStarcat/CircularNatalHoroscopeJS/blob/c65e40d9b901b1143ca14af831e05de9ae004835/src/utilities/astronomy.js#L112

The first condition should be x < 0 (I mean d value), The x (d) value in the formula should be used instead of the ascendant value found in the first condition.

image

const b = sinFromDegrees(obliquityEcliptic) * tanFromDegrees(latitude) const c = cosFromDegrees(obliquityEcliptic) * sinFromDegrees(localSiderealTime) const d = b + c

Line if (d < 0) { ...

So, I've tried a lot and it's true that way (of course it still needs verification)

thanks a lot Onur

0xStarcat commented 4 years ago

Resolved by #2