search

0xStarcat / CircularNatalHoroscopeJS

An ES6 library for many astrological chart calculations.
The Unlicense
253 stars 74 forks source link

Typescript #10

Closed KevinMartins367 closed 3 years ago

KevinMartins367 commented 3 years ago

my correction suggestion

0xStarcat commented 3 years ago

I left a few questions in the files -

Is the main solution here to move the .d.ts files out of the dist/types directory? Or did you also need to change the main and module keys in package.json ?

I just want to make sure this still works for non-typescript users.

0xStarcat commented 3 years ago

I found the solution and released it https://github.com/0xStarcat/CircularNatalHoroscopeJS/releases/tag/v1.0.13

I needed to point the types key in package.json to the correct index file - dist/types/src/index.

Thank you for jumping in to help!

https://github.com/0xStarcat/CircularNatalHoroscopeJS/pull/13