Refactor gnosis queries for user's roles

ilikesymmetry commented 1 year ago

What's included in this pr + description

move queries to Gnosis API within getRolesByProposalId
remove queries to Gnosis API from RoleSignature
add new hook useGetUsersRoles to get the roles of a user by checking on address comparison to role or role's safe's signers
add new hook useGetUsersRolesCanApprove to get the roles that use also can approve right now
refactor places using these hooks (RoleSignatureView, RoleSignature, ApproveProposalModal, ProposalStepper)

Motivation & Context

remove network calls from useGetUsersRoleCanSignFor to simplify logic and make use of caching
split the useGetUsersRoleCanSignFor hook into different hooks to be easier to compose
improve hook legibility enables easier devX to expand functionality (motivating use case that started this)

Steps to test

For each case, propose for the combination and verify that you are still able to approve and pay as normal:

Author = Contributor || Client
Contributor || Client are a multisig and other is NOT on multisig
Contributor || Client are a multisig and other IS on multisig (to check double-counting signatures)

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
web	✅ Ready (Inspect)	Visit Preview	Oct 28, 2022 at 2:23PM (UTC)

linear[bot] commented 1 year ago

WEB-978 Refactor gnosis queries for role quorum + signers data

kristencheung commented 1 year ago

I'm testing out the branch, but there's no way for me to approve a multisig from the stepper 🤔 @mcgingras @symmtry is this a known issue?

kristencheung commented 1 year ago

I can approve here, but not on the stepper 🤔

kristencheung commented 1 year ago

I'm getting an error when I try to approve as a contributor, but the client is a multisig account that I'm also a part of. see the dev console, where the error is "missing representing role ids"

0xStation / proposer