search

0xStation / proposer

1 stars 0 forks source link

retro feedback on stepper #731

Closed mcgingras closed 1 year ago

mcgingras commented 1 year ago

What's included in this pr + description

retro fixes for stepper

Motivation & Context

fixing bugs we didn't get in time before blitz

Outstanding issues

execute from gnosis didn't work on my last try? Have to test a bit more tomorrow morning.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
web ✅ Ready (Inspect) Visit Preview Nov 3, 2022 at 4:18PM (UTC)
kristencheung commented 1 year ago

@mcgingras looks like you have some merge conflicts from the copy mind added!

kristencheung commented 1 year ago

somewhat unrelated to this pr, but after paying I still see the notification icon that I have an active payment

image
kristencheung commented 1 year ago

Thanks for addressing the fixes! One comment here on whether we need to update the action in the send step to be a send action instead of payment. Otherwise, looks good! I think the notification icons are a nice add, I think the most ideal would be to always show a role that has a cta first, but that does add some complexity.