0xStation / proposer

1 stars 0 forks source link

Editing a proposal #738

Closed kristencheung closed 1 year ago

kristencheung commented 1 year ago

What's included in this pr + description

Motivation & Context

Given the name of the product, “Proposer”, there is an expectation set for people using the app that a proposal is a suggestion or plan for action and therefore should be further iterated on by the relevant parties to come to a completion, a.k.a close the loop. Without being able to finalize the proposal content’s terms, collaborators on the proposal will have a difficult time approving a proposal in a primitive state which is our Q4 metric. While we support the creation of a proposal in-app, we don’t allow for editing of any form and require authors to re-submit their proposals for changes.

Steps to test

Run through each proposal form:

Happy path:

  1. create the proposal
  2. Edit the proposal while connected to the address you used to create the proposal
  3. Add an annotation
  4. Check on proposal history to see the version increase

Unhappy path:

  1. Create the proposal, but don't sign the authorship
  2. Check to see if you can see the proposal anywhere on your workspace (you shouldn't)
  3. Create the proposal and sign the signature
  4. Edit the proposal
  5. exit out of the confirmation modal to make sure the changes are still there, but not saved
  6. confirm the changes (with annotation + without annotation).
  7. Check on proposal history
vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
web ✅ Ready (Inspect) Visit Preview Nov 8, 2022 at 10:57PM (UTC)
linear[bot] commented 1 year ago
WEB-979 Editing proposal post-submission

p0 designs: [https://www.figma.com/file/dEkMwNyiRBGezorxrW5iP4/S11?node-id=286%3A52485](https://www.figma.com/file/dEkMwNyiRBGezorxrW5iP4/S11?node-id=286%3A52485) ~p0 Toolbar spec and prototype in card:~ [~https://www.figma.com/file/dEkMwNyiRBGezorxrW5iP4/S11?node-id=252%3A31181~](https://www.figma.com/file/dEkMwNyiRBGezorxrW5iP4/S11?node-id=252%3A31181) toolbar is moved to s12 Annotated ideal, non-scoped designs and prototype in card: [https://www.figma.com/file/dEkMwNyiRBGezorxrW5iP4/S11?node-id=122%3A15829](https://www.figma.com/file/dEkMwNyiRBGezorxrW5iP4/S11?node-id=122%3A15829) Implementation breakdown (see [pre-implementation plan](https://www.figma.com/file/bKNHgtJrFyG8cn7iyzv89v/Proposal-Editing-History?node-id=0%3A1)): * Proposal version migration  * Add proposal version to proposal object  * Add proposal version to Proposal Signature  * Add proposal version to proposal signature type - update the version. * Create a ProposalHistory table  * Run script to update previous proposals to have a proposal version, proposal history table, and signatures to have a proposal version  * Create UI * Edit a proposal button + tooltip for permissioning  * Info Modal for resetting signatures  * New page for editing + form for editing  * Mutations  * Mutation to update a proposal metadata * Mutation to create proposalHistory object with proposal signature message * Mutation to update proposalHistory object with an annotation about the change Additional: tracking