0xStation / proposer

1 stars 0 forks source link

Commenting on proposals #739

Closed mcgingras closed 2 years ago

mcgingras commented 2 years ago

What's included in this pr + description

UI components and mutation to support commenting on proposals.

Motivation & Context

Giving folks the ability to leave lightweight feedback in our app.

Steps to test

without permissions

  1. go to a proposal
  2. make sure you dont have permissions
  3. make sure no comment info shows up under the proposal

with permissions

  1. go to a fresh proposal with no comments (to test entire flow)
  2. click "start a conversation"
  3. add your comment
  4. verify the comment shows up
  5. test a reply by replying in the comment box
  6. test starting a new thread by clicking new thread button

Screenshots and/or loom video

Screenshot 2022-11-03 at 4 03 13 PM

Outstanding issues

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
web ✅ Ready (Inspect) Visit Preview Nov 8, 2022 at 7:06PM (UTC)
linear[bot] commented 2 years ago
WEB-996 In-app feedback

Designs here: [https://www.figma.com/file/dEkMwNyiRBGezorxrW5iP4/S11?node-id=388%3A37405](https://www.figma.com/file/dEkMwNyiRBGezorxrW5iP4/S11?node-id=388%3A37405) **Decision**: use position 1, and to remove direct reply/quote functionality.

ilikesymmetry commented 2 years ago

Something with pfp is not working on comment component?

image