0xStation / proposer

1 stars 0 forks source link

reset signatures on edit #751

Closed kristencheung closed 1 year ago

kristencheung commented 1 year ago

What's included in this pr + description

forgot to reset the signatures when we edit the proposal 👀, but I'm doing it now!

Basically on approval of the proposal, we should generate a proposal signature with the current proposal version.

Whenever we're checking for approvals, we need to double check that the signatures correlate to the correct proposal version.

Upon editing the proposal, we reset the approval status back to pending

Steps to test

  1. Create a proposal
  2. Approve the proposal (not fully though)
  3. Edit the proposal and check to see that the signatures are reset
  4. Try approving and editing again, to make sure there are no edge cases.
vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
web ✅ Ready (Inspect) Visit Preview Nov 11, 2022 at 8:38PM (UTC)
what-the-diff[bot] commented 1 year ago
what-the-diff[bot] commented 1 year ago