Enable flexible RFP payment definitions

[ilikesymmetry]

What's included in this pr + description

• Refactor RFP metadata model to not use Templates
• Make RFP payment form fields optional
• Make responding proposal form dynamically ask for inputs depending on what is provided by RFP
• Update RFP metadata sidebar with new data model
• Update RFP editing with new data model
• Data migration script from old RFP templates to new RFP metadata

Motivation & Context

• RFP requesters may not want to fix proposal details, but apply partial constraints on them (e.g. >100 USDC)

Steps to test

Create RFP flow

1. Same details on first step
2. Still select a payment direction
3. Token is default "Flexible", Payment terms is default "Flexible" and I can click Next
4. If I choose a token, Payment amount is default to "Flexible" and I can click Next
5. Payment amount lets me choose "Fixed", "Minimum", and "Maximum" with a required positive number input below
6. Requirements step is same as before

Propose to RFP flow

1. Same details on first step
2. Payment step shows context of what RFP has preselected for me
3. Payment step lets me fill out remaining form fields with proper validation
4. Confirm step is same
5. Correctly creates proposal on completion

Edit RFP flow

• Can edit all terms normally

Screenshots

Outstanding issues

• Does not support "No payment" option yet for RFPs, blocked by role refactor first

[linear[bot]]

WEB-1014 Enable flexible RFP payment metadata and conditions

Not every RFP needs to specify payment per proposal [image.png](https://uploads.linear.app/e186bf5f-a55d-4799-9233-adcf54b8efd4/76794a20-5e1e-41be-88bc-a407449fdd0c/68e80858-df5b-4a66-96dd-216ebbf816d3) [image.png](https://uploads.linear.app/e186bf5f-a55d-4799-9233-adcf54b8efd4/86f5bce0-6cb2-4f77-839b-bac178912ff3/f0ba0700-9ef8-46a5-a1d7-9773cdf4638b)

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
web	✅ Ready (Inspect)	Visit Preview	Nov 16, 2022 at 8:47PM (UTC)

[what-the-diff[bot]]

• Changed the name of ProposalFormStep.REWARDS to "Rewards"
• Added chainId property to network coin and stablecoins in getNetworkCoin() and getNetworkTokens(). This is needed for token transfers on different networks (e.g., mainnet, testnets)
• Moved generateMilestonePayments function from app/proposal/utils into createProposal mutation resolver so that it can be used by both proposal form submission as well as RFPs 4a-b: Renamed advancedPaymentPercentage field to advancePaymentPercentage throughout codebase because we are using a custom validator which checks if value is between 0 - 100% inclusive; this was causing an error when submitting proposals with payment terms set to ADVANCE_PAYMENT since our validation logic expects input values named 'advance' not 'advanced'. We also renamed all references of advanced -> advance in comments where appropriate for consistency's sake :)
• Added a new component
• Updated the imports to use absolute paths instead of relative ones
• Fixed some typos in comments and strings (e.g., "Add" -> "@")
• Changed <p> tags to be self-closing, e.g.:

  vs

• Added a new file
• Changed the name of some variables and functions to be more descriptive
• Removed unnecessary code that was not being used in this component (e.g., useEffect, useState)
• Fixed an issue where the network dropdown would show up even if there is no token selected yet for payment amount details on step 1 of RFP proposal form creation flow
• Added paymentAmountType to RfpSidebar
• Updated getPaymentDetails in utils/index.tsx and added PaymentAmountType enum
• Removed unused imports from form/form.tsx, updated createRFP mutation with new fields for min amount, max amount, advance percentage (which is now a float), requester role type and proposer role type which are both enums of ProposalRoleTypes defined in the prisma schema file under proposal_role_type field on proposals table
• Fixed bug where if you didn't select any tokens it would throw an error when creating rfp because token was undefined but not checked before being passed into the query as part of payment object so I wrapped that check around it to make sure there's actually a selectedToken first before passing anything through otherwise just pass null or undefined instead since those are valid values for this field according to graphql spec
• Added PaymentAmountType enum
• Changed the payment amount type to flexible by default and added a dropdown for selecting different types of payments (fixed, minimum, maximum)
• Updated validation logic based on selected token address and payment amount type
• Fixed some typos in comments/labels etc...
• Removed associatedAccountAddress, preselectClientAddress and preselectContributorAddress from createRfp mutation
• Added requesterRole to updateRfpContent mutation
• Changed payment object in createRfp and updatedPayment mutations: removed token, amount, terms fields; added minAmount (optional), maxAmount (optional) and terms (enum of PaymentTerm). Also changed advancePaymentPercentage field type to optional number instead of required number with default value 100%
• Moved proposal related data out of RFP metadata into a new "proposal" key inside the same metadata object
• Rename ProposalTemplateForm to ProposalRfpForm
• Remove templateId from the route and replace with rfpId
• Replace all references of template in this file with rfp (e.g., getPaymentToken(template?... -> getPaymentToken(rfp?...) )
• Add new imports for paymentAmountDetails, PAYMENT_TERM_MAP, PaymentTerm at top of page: import {getPaymentAmountDetails} from "app/rfp/utils" ; import {PAYMENT_TERM_MAP} from "app/core/utils";import { PaymentTerm }from "app/proposalPaymentsTypes"

[mindapivessa]

Change "Rewards" to "Payment" for the second step

Remove "The following details have already been set by this RFP." It's clear from the design.

User should also be able to choose Payment terms flexibility