0xStation / proposer

1 stars 0 forks source link

Edit payment #807

Closed kristencheung closed 1 year ago

kristencheung commented 1 year ago

What's included in this pr + description

This pr introduces editing payment!

If you are an author, you can go to the proposal page to edit a payment as long as the proposal hasn't been fully approved. Once the payment is edited, your signatures will reset and the proposal history tab will update with a new version displaying the changes of the before and after history.

You can edit:

You can't edit:

The recipient address is supported in the code, but is hidden visually with css

Motivation & Context

People want to be able to edit their payments in order to come to agree on the terms of the proposal

Steps to test

Create a proposal with payment:

edit to different payments trying out all the different payment terms permutations:

advanced payment -> pay on completion

pay on completion -> pay on approval 

pay on approval -> advanced payment etc, etc. 

Test editing payment by creating a proposal to an RFP.

Test import token

Test actually paying the payment terms

Screenshots and/or loom video

image image image

Outstanding issues

Need to bring back the network selection dropdown on the proposal creation form to be in parity with the editing form

Relevant docs

N/A

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
web ✅ Ready (Inspect) Visit Preview Dec 16, 2022 at 7:27PM (UTC)