Query nonce for safe tx hash from safe API for execution success hook - Githubissues

0xStation / proposer

1 stars 0 forks source link

Query nonce for safe tx hash from safe API for execution success hook #813

Closed ilikesymmetry closed 1 year ago

ilikesymmetry commented 1 year ago

What's included in this pr + description

change nonce query from live on-chain data to Safe's API to match a specific ExecutionSuccess event with its nonce manually versus inferring

Motivation & Context

should resolve a problem with batch transactions where the highest nonce transaction was improperly labeled as "rejected"

Steps to test

Non-batch test

queue a transaction from a proposal
execute transaction from our UI (repeat for from Gnosis' UI)
see transaction state marked as success and proposal state as complete

Batch execution test

queue multiple transactions from proposals
execute as a batch in one transaction
see transaction state marked as success for all (especially highest nonce transaction)

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
web	✅ Ready (Inspect)	Visit Preview	Jan 12, 2023 at 1:21AM (UTC)