search

0xacx / chatGPT-shell-cli

Simple shell script to use OpenAI's ChatGPT and DALL-E from the terminal. No Python or JS required.
https://gptshell.cc
MIT License
1.05k stars 150 forks source link

Good practices: Do not automatically add env vars to .profile #48

Closed Zeioth closed 1 year ago

Zeioth commented 1 year ago

It is ok to ask the user to define the env vars, but it is a bad idea to touch the .profile file ourselves from the installer.

0xacx commented 1 year ago

I agree, it is a bit invasive but I think that users who care about it, would not use the installer anyway and just install the script manually. But, for users that don't know where their shell profile is and how to edit it, the script is very useful. I added a question before editing the shell profile, so it is crystal clear to anyone what happens when running the install script. 👍