Full selected text not available for copying

0xbad1d3a5 / Kaku

画 - Japanese OCR Dictionary

https://kaku.fuwafuwa.ca/

BSD 3-Clause "New" or "Revised" License

210 stars 36 forks source link

Full selected text not available for copying #18

Closed SpongebobSquamirez closed 5 years ago

SpongebobSquamirez commented 5 years ago

In normal (non-instant) mode, Kaku used to at least allow you to copy the entire selection of text, by performing OCR on the whole thing, even if it didn't have space to display the full result. I'd like this feature back in some form so that I can copy sentences to create Anki cards.

0xbad1d3a5 commented 5 years ago

I pushed v1.3.46 to the beta which should address this issue. Can you test it out @weirdalsuperfan?

SpongebobSquamirez commented 5 years ago

Thanks for that! It looks like it works.

Unless you have another use for the bottom corners, it would be nice if they were included in the "sides" used to scroll with. The bottom looks pretty open, but the sides are tight and even with my tiny fingers clicking the sides without accidentally selecting a character is a delicate exercise. Screenshot_20190311-210622_Chrome

0xbad1d3a5 commented 5 years ago

Hmm... not sure why you're having a hard time tapping, from your image the tap area should be roughly the size of the kanji (I'm eyeballing here, but the red should show the trigger area):

Including it in the bottom part of the window is a bit difficult, since that's also where the ScrollView is. It looks empty when there's no kanji selected but fills up after the the definition comes in.

0xbad1d3a5 commented 5 years ago

Closing issue since feature is now in prod and haven't heard about any complaints. Let me know if trying to touch the edge is still a problem after a while though.