0xbitches / sd-webui-lcm

Latent Consistency Model for AUTOMATIC1111 Stable Diffusion WebUI
MIT License
614 stars 43 forks source link

add ability to run LCM on CPU #20

Closed by321 closed 9 months ago

ljleb commented 9 months ago

I mentioned this in #22, IMO we should consider using the properties exposed by the webui in modules.devices instead of adding a new checkbox. Do you think this could cause problems?

0xbitches commented 9 months ago

I think people who wants to run on CPUs are not necessarily running A1111 itself on CPU. In my opinion, having a checkbox for the user to choose is still the better approach.

0xbitches commented 9 months ago

@by321 @ljleb Thanks for the contribution. I have decided to use modules.devices by default, then override it with cpu should the user choose to.

by321 commented 9 months ago

Just a note: I just found out many modern CPUs have support for FP16 (although I couldn't get it to work on my machine even though the CPU supports FP16 instructions), so maybe automatically overriding FP16 with FP32 in CPU mode isn't a good idea.

Maybe just add "may not work in CPU mode" to the FP16 checkbox text.