0xbs / premade-groups-filter

A World of Warcraft addon for powerful filtering of premade group listings.
GNU General Public License v2.0
76 stars 40 forks source link

For dungeon search, surface partyfit in options #169

Closed redcatelf closed 1 year ago

redcatelf commented 1 year ago

As an m+ player, I find that "partyfit" is by far the most useful filter option in this addon. Right now it's only discoverable if you read the whole keyword list and aren't being put off by making your own advanced expression query.

I wonder if it might make sense to surface partyfit in the options, at least when you're in the dungeon search pane? For dungeon search, partyfit seems like it mostly obviates the need for setting min/max on group members or tanks/dps/healers, so perhaps it makes sense to replace it like this:

image

Again, this change would presumably only apply for dungeon search.

(If you end up implementing #168, adding the lustfit keyword as another option here might make sense as well, perhaps conditional only if your party doesn't already contain a bloodlust class, so as to not be confusing.)

0xbs commented 1 year ago

Yes I should do that. Had the case that I was playing with a friend that did both DPS and heal, so partyfit did not work, but I was using expert mode anyway so no problem.

There is also #118 where I thought about showing only the relevant options like M+ rating only for M+ searches.

0xbs commented 1 year ago

There is now version 4.0.0-beta.1 that shows a different filter window for each category. Please have a look and tell me what you think.

0xbs commented 1 year ago

Now implemented!