search

0xbs / premade-groups-filter

A World of Warcraft addon for powerful filtering of premade group listings.
GNU General Public License v2.0
76 stars 40 forks source link

I think the raid progress filter (rioheroicprogress specifically) isn't working correctly. #209

Closed gotex007 closed 1 year ago

gotex007 commented 1 year ago

If I sort by rioheroicprogress>8 (aotc only) then it filters out two of the three groups that do meet this criteria for some reason. I think rioheroicprogress might be looking at their main's progress because it's happening with no other filters (other than heroic) enabled and I can't figure out out why two eligible groups are filtered.

My Search The found eligible group The first group not found and The second group not found

0xbs commented 1 year ago

Your queries are correct and the two groups should appear in the search.

I suspect that there is indeed a bug in the calculation logic if the raid leader has progress in multiple raids and the last one in the list is not the desired raid. The code loops over all progress entries and the last one "wins".

I will check if that is really the case. If yes, I wonder how to fix it. I could use the first entry instead. Or I could calculate the maximum. Or I can try to associate Rio's abbreviations with the current activity but that requires an update on each new raid :/