search

0xbs / premade-groups-filter

A World of Warcraft addon for powerful filtering of premade group listings.
GNU General Public License v2.0
76 stars 40 forks source link

Fixed dungeon order in panel. #227

Closed dsabecky closed 6 months ago

0xbs commented 11 months ago

Thank you for your PR!

It looks like you sorted alphabetically by English names, which works fine for English, but not for all other languages. If we sort alphabetically, it should work for all languages.

Why exactly you prefer alphabetically to the previous order by expansion?

Also this would change the order but keep the state of checkboxes which might be confusing. If we implement alphabetical sorting, this would also imply that other dungeons are checked if someone changes language, however this should happen rather rarely.

dsabecky commented 11 months ago

The regular sorting just isn't conveyed very well is all. If English sorting isn't something you'd want to use as a standard then possibly adding an option to sort by name or to add a context separator showing which expansion they are from. I didn't even realize it was originally sorted by expansion, I just had to eyeball the list 4-5 times to find the dungeon I was looking for.

0xbs commented 11 months ago

It looks like non of the options are really satisfying.

  1. Keeping it sorted by expansion is confusing enough that you created a PR.
  2. Changing it to the proposed fixed English sorting would mean that it is non-alphabetical and looks completely random in other languages.
  3. Using a dynamic alphabetical sorting at startup using full names would mean that dungeons prefixed with "The" are sorted lower than your suggestion. Same for articles in other languages. Also means that checkbox states are messed up after the update, however that's a one time.
  4. Using a dynamic alphabetical sorting at startup using short names (stripped prefixes) would mean that DOTI dungeons are not next to each other in most languages (works coincidentally in English) which I think is very confusing. Checkbox states are messed up once.

Currently I would stick with 1 (it's just 8 dungeons) or go for 3.

0xbs commented 6 months ago

PR no longer relevant as we're now in season 4, which uses alphabetical sorting anyway.