search

0xbs / premade-groups-filter

A World of Warcraft addon for powerful filtering of premade group listings.
GNU General Public License v2.0
76 stars 40 forks source link

matchingid/bossesahead wrong when no lockout #268

Closed mbattersby closed 2 months ago

mbattersby commented 3 months ago

Game Version

Retail

Current behaviour

bossesahead returns 0 (and by extension matchingid is true) when the group has defeated bosses but the player has no lockout. It should consider all the bosses defeated as being ahead and matchingid to be false.

Fix is to change the last fallback return of PGF.GetLockoutInfo to:

return numGroupDefeated, 0, 0, 0, numGroupDefeated, 0

0xbs commented 3 months ago

Thanks for pointing this out and already doing an analysis. Will release an update shortly.