Closed SoneeJohn closed 6 years ago
Merging #356 into develop will increase coverage by
0.1%
. The diff coverage is94.6%
.
@@ Coverage Diff @@
## develop #356 +/- ##
=========================================
+ Coverage 93.4% 93.5% +0.1%
=========================================
Files 8 9 +1
Lines 514 602 +88
Branches 69 86 +17
=========================================
+ Hits 480 563 +83
- Misses 31 35 +4
- Partials 3 4 +1
Impacted Files | Coverage Δ | |
---|---|---|
XCDYouTubeKit/XCDYouTubeVideoOperation.m | 95.8% <100%> (+0.5%) |
:arrow_up: |
XCDYouTubeKit/XCDYouTubeDashManifestXML.m | 89.7% <89.7%> (ø) |
|
XCDYouTubeKit/XCDYouTubeVideo.m | 95.1% <95.2%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f59489c...5698d4e. Read the comment docs.
TODO:
[x] Add new unit tests
[x] Ensure dynamic typed manifests aren't used. Only allow static.
[x] Fix issue with 'Jk3IjaSfB2A' (Has to Dash manifest URLs one is unavailable the other is) Update: Seems to be an issue with the dash manifest being geo blocked – US. Works fine as intended when tested from a different location (US)
354