search

0xced / XCDYouTubeKit

YouTube video player for iOS, tvOS and macOS
MIT License
2.92k stars 627 forks source link

Library Cleanup #390

Closed SoneeJohn closed 6 years ago

SoneeJohn commented 6 years ago

Need to make some more changes.

SoneeJohn commented 6 years ago

Updating existing tests

Sokalay commented 6 years ago

Updating existing tests

Thank you so much, it is working.

oososo commented 6 years ago

Thank you for update John

CWftw commented 6 years ago

Is anyone else experiencing no longer getting back 720p (itag 22) on music videos? For example: https://www.youtube.com/watch?v=yWfsla_Uh80

SoneeJohn commented 6 years ago

@CWftw that video does have an 720p version but it does not contain audio (itag 136)

eloyer commented 6 years ago

Thanks @SoneeJohn for the fix—are you planning to address the failed checks?

fragm commented 6 years ago

@CWftw I encountered the same issue. I can't get 720p on all music videos since yesterday.

eloyer commented 6 years ago

Thank you @SoneeJohn — @0xced what are prospects for a merge? (Would love to see this fix added to a release so the CocoaPods distro can be updated.) Thanks!

eloyer commented 6 years ago

Thanks much @SoneeJohn !