0xced / XCDYouTubeKit

YouTube video player for iOS, tvOS and macOS
MIT License
2.92k stars 626 forks source link

Exclude plist files from SPM #478

Closed AndreiVidrasco closed 4 years ago

AndreiVidrasco commented 4 years ago

At the moment when building the library via SPM, it produces 3 warnings because plist files are added in the project as compilable files. This PR excludes them from SPM

About warning: https://stackoverflow.com/questions/6509600/compilation-warning-no-rule-to-process-file-for-architecture-i386

Screenshot:

warnings
SoneeJohn commented 4 years ago

@AndreiVidrasco Thanks for the contribution. I remember trying to this before but it still gave me that error. https://github.com/0xced/XCDYouTubeKit/commit/0054d0d4a5a8686c7c69c282fbaee01197cb7a20

Can you confirm with this change you are no longer getting errors?

AndreiVidrasco commented 4 years ago

I checked by running simple swift build on latest master(and seeing a lot of warnings) and then running on this branch(without any warnings) Here is a small video with proof https://youtu.be/8sdiRSd70iQ