search

0xced / XCDYouTubeKit

YouTube video player for iOS, tvOS and macOS
MIT License
2.92k stars 626 forks source link

Report error instead of throwing assertion #479

Closed accannis closed 4 years ago

accannis commented 4 years ago

Can you catch assertions and send us an error instead of throwing? Or compile out the NSAssert calls? (Or mark the function call to throw so we can catch it?)

Stack trace is below. Attached is also the response that is triggering the library to take down the app.

accannis commented 4 years ago

curl.txt

accannis commented 4 years ago

CrashLog.txt

accannis commented 4 years ago 
2020-04-30 13:12:24.583084-0700 Rheo[31918:13802149] *** Assertion failure in -[XCDYouTubeVideoOperation handleConnectionSuccessWithData:response:requestType:], /Users/rick/Library/Developer/Xcode/DerivedData/Rheo-hkhirbqvwbfhgucmdjlskuimmtaw/SourcePackages/checkouts/XCDYouTubeKit/XCDYouTubeKit/XCDYouTubeVideoOperation.m:186
2020-04-30 13:12:24.588640-0700 Rheo[31918:13802498] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Failed to decode response from https://www.youtube.com/get_video_info?el=embedded&hl=en&ps=default&video_id=gTbU9M6Q6Ts (response.textEncodingName = utf-8, data.length = 0)'
*** First throw call stack:
(
    0   CoreFoundation                      0x00007fff23e39f0e __exceptionPreprocess + 350
    1   libobjc.A.dylib                     0x00007fff50ad79b2 objc_exception_throw + 48
    2   CoreFoundation                      0x00007fff23e39c88 +[NSException raise:format:arguments:] + 88
    3   Foundation                          0x00007fff258a3cd2 -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 191
    4   RheoEngine                          0x0000000102fc11a7 -[XCDYouTubeVideoOperation handleConnectionSuccessWithData:response:requestType:] + 999
SoneeJohn commented 4 years ago

I will look into using an error instead of throwing an assertion.

billidani7 commented 4 years ago

i am facing the same problem

billidani7 commented 4 years ago

I run into this problem since yesterday. Every single try to load any video ended up to this assertion.

After some tests I release that my IP address get banned. I switched to 4G connection and the problem stopped. Also I restarted my router but after watching few videos my ip get banned again. Has anyone run into the same problem?