0xd4d / dnlib

Reads and writes .NET assemblies and modules
MIT License
2.18k stars 587 forks source link

Fix incorrect column sizes when writing portable or embedded PDB files #532

Closed ElektroKill closed 1 year ago

ElektroKill commented 1 year ago

Fixes https://github.com/0xd4d/dnlib/issues/530

The fix was implemented by adjusting the row counts passed into the InitializeSizes to fix a bug where the row counts were incorrect. The patch is heavily based on the code from TablesStream: https://github.com/0xd4d/dnlib/blob/67396c0e5c3a8c27ac220aa5b3692fcf49f44ebf/src/DotNet/MD/TablesStream.cs#L254-L265

wtfsck commented 1 year ago

Thanks!

jespanag commented 1 year ago

Thank you @ElektroKill !! ❤️