search

0xdevalias / chrome-NewWindowWithTabsToRight

Create a new window from the tabs to the right of the currently selected tab.
https://www.devalias.net/dev/chrome-extensions/new-window-with-tabs-to-right/
MIT License
6 stars 2 forks source link

keyboard shortcut #3

Closed astral-grayson closed 6 years ago

astral-grayson commented 6 years ago

Added the ability to set a keyboard shortcut (by default, Command+Shift+Y) to pop tabs to the right into a new window.

0xdevalias commented 6 years ago

Thanks for the PR @OliverGray Looks good from a casual skim, but need to make some time to check things out before I merge it.

Do you know how hard it is (if possible) to make the bound key configurable from an 'options' page? This makes it easy to change for a user building their own extension, but not so good from the extension store. I think I would want to have that ability included before I merged/added this to the store build.

astral-grayson commented 6 years ago

It's actually already in there by default, in chrome://extensions you click on the top left hamburger and go to "keyboard shortcuts" and can edit all the bind keys for your extensions. By the way, I love this extension, it's so useful!

If you wanted to have a specific options page for this app it seems doable but I'm not totally sure how, I'm pretty new to Chrome extensions.

0xdevalias commented 6 years ago

Ah, that is cool. Never even looked at that page before!

Docs ref: https://developer.chrome.com/extensions/commands

Eventually I would like to rewrite/expand on this extension a bit, but forever doing too many other things. So if I ever get around to it, and it makes sense to, that's when i'll look at including an options page.

I see that you've added the manifest for newWindowWithTabsToRight but not newWindowWithThisAndTabsToRight. If you could add that as well, then i'd be happy to merge this.

Will then need to make time/sit down at some point and figure out the release process on the app store again to get it up there. Has been a while.. :p

Thanks for the contribution (and the kind words)!

astral-grayson commented 6 years ago

Added a manifest for the current tab option. I find myself using the "tabs to the right" option more than the current one... supporting that function must have slipped my mind. Oops!

0xdevalias commented 6 years ago

Hehe, all good :)

Will merge now, and hopefully re-remember the upload process over the weekend! Thanks for the PR! It's awesome to hear how things I made for myself are useful to others too :3

0xdevalias commented 5 years ago

@OliverGrayson Just bumped the version on the chrome store with your changes included. Thanks again!