0xf005ba11 / vmplex-ws

A tabbed UI for Microsoft's Hyper-V
MIT License
204 stars 15 forks source link

[Feature request] add colors to the toolbar buttons #19

Open ghost opened 2 years ago

ghost commented 2 years ago

For example, when VM is on, this button should ideally be green showing that VM is on, when VM is off, it can be in red colors

image

the rest of the buttons can have colors too for better visibility and recognition. Thanks

jxy-s commented 2 years ago

I think this should be an option for users to customize the look and feel of the program. Rather than having them be forced into a theme/color scheme that isn't patterned elsewhere in the OS. With the button coloring option on, I could see the buttons being colored to match the chosen system accent color, and multi purpose buttons changing based on their current function.

ghost commented 2 years ago

I think this should be an option for users to customize the look and feel of the program. Rather than having them be forced into a theme/color scheme that isn't patterned elsewhere in the OS. With the button coloring option on, I could see the buttons being colored to match the chosen system accent color, and multi purpose buttons changing based on their current function.

it is used in other parts of the OS, I'm talking about this: image image image

using system accent color isn't what I'm suggesting, that'd be useless because again all buttons would have the same color. they are all white, then they would be all purple for example.

jxy-s commented 2 years ago

Could you make a recommendation for an icon set that is free for an open source project to use? One which matches the style you desire.

It's easiest for us to use the existing font icons provided by the framework. These match with the modern design language of the program best out-of-the-box. @0xf005ba11 and myself are primarily kernel engineers, that's to say our "sense of design" is lacking 😉. That said, I'd welcome an icon set from the community that matches the modern design goals of the project.

In my experience finding one icon that is license free is a pain, let alone a set that share a common theme. Perhaps there is a resource out there that I'm not familiar with.

ghost commented 2 years ago

Could you make a recommendation for an icon set that is free for an open source project to use? One which matches the style you desire.

It's easiest for us to use the existing font icons provided by the framework. These match with the modern design language of the program best out-of-the-box. @0xf005ba11 and myself are primarily kernel engineers, that's to say our "sense of design" is lacking 😉. That said, I'd welcome an icon set from the community that matches the modern design goals of the project.

In my experience finding one icon that is license free is a pain, let alone a set that share a common theme. Perhaps there is a resource out there that I'm not familiar with.

Oh, I wasn't aware that it's such a hassle to implement icons 😁kudos to the designers unfortunately no, I'm not familiar with any open source icons pack either, so in that case, I think it's better to ignore this feature request as it's not probably worth the effort.

I had thought it'd possible to simply change the colors of the buttons you already implemented in the current UI, like you know, add a color code to the button when it's active and when it's inactive, but if it's not possible, the current design will work fine :)

jxy-s commented 2 years ago

Color is possible on the current font icons, I believe. But that's what I recommended in the first option. I think maybe we spoke past one another. Or I did a poor job at conveying my thoughts.

I'll try some color adjustments when I have time and post a screenshot here for your input.

ghost commented 2 years ago

Color is possible on the current font icons, I believe. But that's what I recommended in the first option. I think maybe we spoke past one another. Or I did a poor job at conveying my thoughts.

I'll try some color adjustments when I have time and post a screenshot here for your input.

no you're right, I totally missed that part, thank you, looking forward to that :)

jxy-s commented 2 years ago

Here is the first pass, I don't really like how this is at the moment, but to give you an idea: image

ghost commented 2 years ago

That looks good 👍 maybe the moon icon can be yellow. the recycle being red is great.