0xf104a / NextcloudServices

Android app to send notifications from Nextcloud without using GCM(Google cloud messaging)
GNU General Public License v3.0
65 stars 11 forks source link

Improve "Credits" activity #17

Closed 0xf104a closed 3 years ago

0xf104a commented 3 years ago

Credits activity currently very simple and so do not have enough information as well as being inconvinient for user. So following changes should be introduced:

Devansh-gaur-1611 commented 3 years ago

Hello, I want to contribute to this issue as a beginner but I am unable to find the credits activity. Can anyone please help me by telling me that where it is present

0xf104a commented 3 years ago

Hello. Sorry for this: I just forgot to rename it since it was initially designed for only putting licenses, but now I think there should be all people who contributed to this project. So I have just renamed it in last commit :) Now you can find it by path app/src/main/java/com/polar/nextcloudservices/CreditsActivity.java

Devansh-gaur-1611 commented 3 years ago

Thanks for this info

Devansh-gaur-1611 commented 3 years ago

Hello, I have opened the app using android studio. But I am getting an error "Cannot access com.polar.nextcloudservices.NextcloudAbstractAPI" And even after rebuilding it again and again the issue is not solving. Please help me. I have attached the screenshots for the same Screenshot (149) Screenshot (148) Screenshot (147)

0xf104a commented 3 years ago

Since build is succesful(as I can see from last screenshot) it seem to be problem with an Android Studio cache. So I guess doing gradle sync would help, but if it doesn't you can try to do what Stackoverflow is suggested:

Devansh-gaur-1611 commented 3 years ago

Hi, I have created a pull request after solving the first two issues of this issue #17. Please have a look over it. Also please write the last issue of issue #17 in detail please, actually I am unable to understand what to do in the 3rd issue.

0xf104a commented 3 years ago

The third issue was mostly about that I have not imagined way to properly place license name for everyone(so what I've imagined is two lists(inside one activity or even having separate activities),but it is not user-friendly). In fact your implementation solves this problem, because we can use \n in strings, e.g.

<item>Contribution: NumberPickerPreference\nLicense: LGPL-3.0</item>

This would place a "License:..." text under "Contribution:..." line for those people whose contribution has license. So since everything is implemented I'm closing this issue. Thank you once more for your contribution!

Devansh-gaur-1611 commented 3 years ago

Thanks for the compliment. This was my first contribution to open source, and I am glad that my work was helpful to you.