Use same UI-Style as other Nextcloud Android apps

0xf104a / NextcloudServices

Android app to send notifications from Nextcloud without using GCM(Google cloud messaging)

GNU General Public License v3.0

65 stars 11 forks source link

Use same UI-Style as other Nextcloud Android apps #25

Closed newhinton closed 2 years ago

newhinton commented 2 years ago

This introduces a multi-screen layout. It splits the current main view into multiple fragments that can be accessed by a navigation drawer.

0xf104a commented 2 years ago

Hello. Thank you for your contirbution! As far as I see it is not ready yet, so I am marking it as a draft.

newhinton commented 2 years ago

@Andrewerr I have added the basic appbar as the officals app use it. The base functionality of the app works, but most of the ui has no function at the moment. I would still like to hear feedback if that is something you can imagine merging because there is a lot of work still to do!

0xf104a commented 2 years ago

@Andrewerr I have added the basic appbar as the officals app use it. The base functionality of the app works, but most of the ui has no function at the moment. I would still like to hear feedback if that is something you can imagine merging because there is a lot of work still to do!

I like your idea to make the style of this app unified with style of other Nextcloud apps and of course when your changes would be ready I would definetely merge them. Also feel free to ask me to help if you have any issues with integrating my code with yours.

newhinton commented 2 years ago

@Andrewerr I think i have now progressed enough for a review. I have now updated most of the user interface. There are still todos:

[x] Translations are missing in most of the app
[x] There are some Preferences that seemingly do not belong to this app

0xf104a commented 2 years ago

@newhinton Thank you very much for your work! I will add your issue about translation as enhancment to issues list. Also could you please explain what you mean by your second todo since I do not really understand which of preferences do not belong to this app.

newhinton commented 2 years ago

I mean those two categories: Screenshot_20220106-135814_Notifications

i may be mistaken and they do something important, but if they do, they need a better explanation or maybe even their own fragment

Edit: Ignore the Mail-Floating Button, it's a leftover that i haven't yet removed

0xf104a commented 2 years ago

This settings are from default example fragment for preference controller which are provided by android studio and so they can be safely deleted. As per floating button I have no idea how it appeared here, but I think it also can be safely removed.

newhinton commented 2 years ago

@Andrewerr Oh i didn't see your updated comment! I added a few commits that should help with some of the issues, but it should be able to merge just fine!

0xf104a commented 2 years ago

@newhinton I am sorry. There is some issues with translations, so have I misunderstood you and merged this PR too early?

newhinton commented 2 years ago

@Andrewerr not really, i just were in a good mood and just moved many strings to the appropriate file! The pr was good to go and i will probably continue improving it, but the changes will probably far smaller pr's (except maybe the notification history)