search

0xf104a / NextcloudServices

Android app to send notifications from Nextcloud without using GCM(Google cloud messaging)
GNU General Public License v3.0
63 stars 11 forks source link

open chats in custom tab rather than nextcloud talk #47

Closed freeflyk closed 1 year ago

freeflyk commented 1 year ago

Hello Andrewerr.

Since a click on a chat message notification will open nextcloud talk in the main activity rather than the specific chat the message was send from I would like to propose to open a custom browser window instead. The advantage over a common browser activity is that all the layout is reduced to a minimum, the URL cannot be altered and a closing button is presented to close the intent. If you like I can create a pull request for this feature from my branch. I also updated the credits and donate intents ...

GitHubCustomTabsIntent

0xf104a commented 1 year ago

Hello freeflyk. Thankyou for improving intents. Please create pull request from your branch to main branch of this repo

freeflyk commented 1 year ago

Hello andrewerr.

Thanks for considering the pull request. I initially tried to open the nextcloud talk app with the correct chat opened. However, I was not able to open anything beside the main activity of talk. Also I think that this is not intended by the developers in the first place... Thus, I figure that it does not make sense to open talk when tapping on the notification since its not really an improvement over opening talk from the desktop directly. Instead, one could unify the notification response by simply always opening a browser that leads the user directly to the correct page.

0xf104a commented 1 year ago

Closing issue as PR #48 is merged