search

0xfe / vexflow

A JavaScript library for rendering music notation and guitar tablature.
http://www.vexflow.com
Other
3.83k stars 657 forks source link

fix test scroll #1574

Closed rvilarl closed 1 year ago

rvilarl commented 1 year ago

Hi Ron, please look into that, I had to undo some of your chenges in flow.html.

This PR avoids that the tests scroll behind the header.

ronyeh commented 1 year ago

There is still a small bug where the footer links are hidden behind the header, and one of the tests seems to be rendered off to the left. Can you investigate? We can perhaps merge the footer links into the header... since it is less likely someone will scroll all the way to the bottom of the huge page of tests.

Bug1

Additionally, I had added a short sentence saying "Please wait a moment while the tests run....", which your PR removed. I think it would be useful to have that in case the tests take a long time to run. On my machine, the webpage looks broken until the tests all finish:

    <h3>
        Please wait a moment while the tests run....<br /><br />
        See the: <a id="vex-src" target="_blank"></a>. Don't forget to run the
        <a href="https://github.com/0xfe/vexflow/wiki/Visual-Regression-Tests">Visual Regression Tests</a>!
    </h3>