search

0xfe / vexflow

A JavaScript library for rendering music notation and guitar tablature.
http://www.vexflow.com
Other
3.83k stars 657 forks source link

issue #1603 - key signature on non-treble stave, no glyph #1606

Closed AaronDavidNewman closed 5 months ago

AaronDavidNewman commented 6 months ago

Prior to this fix, there was no way to show a key signature correctly in a bass clef stave, without the clef glyph (and any other non-treble). I added a test case and created a stave.addClefLines(clefSpec: string) method that adds the logical clef (e.g. the lines match the clef) but without the glyph.

rvilarl commented 5 months ago

@AaronDavidNewman Thanks for the PR, let me know if you prefer to do the changes or just to let it and merge. Also, would you like to do the same PR in Vexflow 5 or should I do it?

ronyeh commented 5 months ago

After the merge, you can try to cherry pick the commit and apply it to the V5 repo (assuming the modified file isn't substantially different). That way the authorship is preserved, I believe. (Or Aaron can submit the V5 PR himself.)

AaronDavidNewman commented 5 months ago

I updated based on comments and I'll merge it in. I'll look at vex5 soon and submit a PR.